Skip to content

Conversation

@sfc-gh-bchinn
Copy link
Contributor

@sfc-gh-bchinn sfc-gh-bchinn commented Sep 23, 2025

MacOS no longer provides /usr/bin/python, so use python3 instead.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sfc-gh-bchinn sfc-gh-bchinn marked this pull request as ready for review September 23, 2025 17:10
@sfc-gh-bchinn sfc-gh-bchinn requested a review from a team as a code owner September 23, 2025 17:10
@sfc-gh-bchinn sfc-gh-bchinn changed the title Use python3 for check-no-native-http Use python3 for pre-commit hooks Sep 30, 2025
@sfc-gh-turbaszek
Copy link
Contributor

Have you had issues with using python? I think for development (that's where precommits are used) people should have dedicated, preferably isolated virtual environments. Given that I'm not sure if using python3 is required. I would even consider this as misleading guidance that it's ok to run precommits just on system python

@sfc-gh-bchinn
Copy link
Contributor Author

@sfc-gh-turbaszek It looks like snowflake-connector-python only supports 3.9+ anyway, so if development is only expected to occur in virtual environments, what's the harm in switching to python3?

While I agree that development should generally occur in a virtual environment,

  1. The README doesn't mention anything about creating a virtual environment
  2. It's possible to use a virtual environment for development without activating it in your shell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants